On Wed, 2016-04-06 at 22:56 +0300, Andy Shevchenko wrote:
> On Wed, Apr 6, 2016 at 9:56 PM, Vinod Koul <vinod.koul@xxxxxxxxx>
> wrote:
> > On Mon, Apr 04, 2016 at 08:10:54PM +0300, Andy Shevchenko wrote:
> > > On Mon, 2016-04-04 at 10:03 -0700, Vinod Koul wrote:
> > > > On Fri, Mar 18, 2016 at 04:24:40PM +0200, Andy Shevchenko wrote:
> > > > >
> > > > > + /*
> > > > > + * We need controller-specific data to set up slave
> > > > > transfers.
> > > > > + */
> > > > > + BUG_ON(chan->private && !dw_dma_filter(chan, chan-
> > > > > > private));
> > > > I don't think BUG_ON is apt here, gracefully failing and
> > > > printing
> > > > that can
> > > > be better..
> > >
> > > Hm, this is coming from the existing code.
> > >
> > > I would prefer to keep this one as is since it's targeted to
> > > stable@,
> > > and I may issue sequential patch to replace BUG_ON. Sounds okay?
> >
> > But since this is going stable, how about we remove here in the
> > patch and
> > benefit stable tree as well?
>
> I'm fine with that. I will send you patch tomorrow.Other than that do
> we have any issues with the rest?
I did look at few more they looked fine, but didn't look at entire
series
--
~Vinod
��.n��������+%������w��{.n��������)�)�� jg��� �����ݢj����G���� ���j:+v���w�m������w�������h�����٥
