On Thu, Apr 7, 2016 at 12:09 AM, Koul, Vinod <vinod.koul@xxxxxxxxx> wrote: > On Wed, 2016-04-06 at 22:56 +0300, Andy Shevchenko wrote: >> On Wed, Apr 6, 2016 at 9:56 PM, Vinod Koul <vinod.koul@xxxxxxxxx> >> wrote: >> > On Mon, Apr 04, 2016 at 08:10:54PM +0300, Andy Shevchenko wrote: >> > > On Mon, 2016-04-04 at 10:03 -0700, Vinod Koul wrote: >> > > > On Fri, Mar 18, 2016 at 04:24:40PM +0200, Andy Shevchenko wrote: >> > > > > + /* >> > > > > + * We need controller-specific data to set up slave >> > > > > transfers. >> > > > > + */ >> > > > > + BUG_ON(chan->private && !dw_dma_filter(chan, chan- >> > > > > > private)); >> > > > I don't think BUG_ON is apt here, gracefully failing and >> > > > printing >> > > > that can >> > > > be better.. By the way, what level do you want to have warning on? I consider now between dev_warn() and dev_WARN()... >> do >> we have any issues with the rest? > > I did look at few more they looked fine, but didn't look at entire > series Thanks, got it! -- With Best Regards, Andy Shevchenko -- To unsubscribe from this list: send the line "unsubscribe dmaengine" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
