On Tue, Jan 20, 2015 at 10:57:58AM +0200, Andy Shevchenko wrote: > On Tue, 2015-01-20 at 14:41 +0800, Keyon wrote: > > hi, Andy, > > > > will this change disable dw_dma_interrupt when dw_dma is set to off? > > > > I am debugging an ADSP issue on BDW and thinking of that we need disable > > this interrupt(at least disable the interrupt reset part) when no > > channel is used(dw->in_use == 0). > > This driver is not using it at all, so, this patch is a rather cosmetic > change. Do you have this interrupt enabled by some reason (firmware?)? > > If so, then it might make sense to disable it at interrupt handler as > well. And thats precisely we need to fix by using right mechanism available, so I am going to skip this patch as it doesn't seem to solve anything -- ~Vinod -- To unsubscribe from this list: send the line "unsubscribe dmaengine" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html