On Tue, Jan 20, 2015 at 11:09:26AM +0200, Andy Shevchenko wrote: > On Tue, 2015-01-20 at 17:07 +0800, Keyon wrote: > > On 2015年01月20日 16:57, Andy Shevchenko wrote: > > > On Tue, 2015-01-20 at 14:41 +0800, Keyon wrote: > > >> hi, Andy, > > >> > > >> will this change disable dw_dma_interrupt when dw_dma is set to off? > > >> > > >> I am debugging an ADSP issue on BDW and thinking of that we need disable > > >> this interrupt(at least disable the interrupt reset part) when no > > >> channel is used(dw->in_use == 0). > > > This driver is not using it at all, so, this patch is a rather cosmetic > > > change. Do you have this interrupt enabled by some reason (firmware?)? > > yes, the firmware is using the same dma engine, while we set dma > > off(with all channels freed). > > the firmware won't use our kernel dma driver. > > > If so, then it might make sense to disable it at interrupt handler as > > > well. > > yes, I have worked out a small patch for that and will send out to > > review soon. > > It might make sense to fold both patches into one. Anyway, please, send > what you have first. I have said previously that right way is to use PIMR and mask DMA interrupts to host/DSP when we don't want those interrupts. Disabling ISR is _not_ the right solutions here -- ~Vinod -- To unsubscribe from this list: send the line "unsubscribe dmaengine" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
