On Mon, Oct 04, 2021 at 09:01:33AM -0400, Mikulas Patocka wrote: > Do you want this patch? Yes, this looks like what I want. Minor nitpicks below: > + .fallocate_flags = BLKDEV_FALLOC_FL_SUPPORTED, I'd probably call this fallocate_supported_flags. > + .fallocate_flags = FALLOC_FL_KEEP_SIZE | FALLOC_FL_PUNCH_HOLE | FALLOC_FL_ZERO_RANGE, Please avoid over 80 lines for a plain list of flags. -- dm-devel mailing list dm-devel@xxxxxxxxxx https://listman.redhat.com/mailman/listinfo/dm-devel