-----Original Message----- From: Herbert Xu [mailto:herbert@xxxxxxxxxxxxxxxxxxx] Sent: Thursday, December 22, 2016 10:59 AM To: Binoy Jayan Cc: Milan Broz; Oded Golombek; Ofir Drang; Arnd Bergmann; Mark Brown; Alasdair Kergon; David S. Miller; private-kwg@xxxxxxxxxx; dm-devel@xxxxxxxxxx; linux-crypto@xxxxxxxxxxxxxxx; Rajendra; Linux kernel mailing list; linux-raid@xxxxxxxxxxxxxxx; Shaohua Li; Mike Snitzer Subject: Re: dm-crypt optimization On Thu, Dec 22, 2016 at 01:55:59PM +0530, Binoy Jayan wrote: >> >> > Support of bigger block sizes would be unsafe without additional >> > mechanism that provides atomic writes of multiple sectors. Maybe it >> > applies to 4k as well on some devices though...) >> >> Did you mean write to the crypto output buffers or the actual disk write? >> I didn't quite understand how the block size for encryption affects >> atomic writes as it is the block layer which handles them. As far as >> dm-crypt is, concerned it just encrypts/decrypts a 'struct bio' >> instance and submits the IO operation to the block layer. >I think Milan's talking about increasing the real block size, which would obviously require the hardware to be able to write that out atomically, as otherwise it breaks the crypto. > >But if we can instead do the IV generation within the crypto API, then the block size won't be an issue at all. Because you can supply as many blocks as you want and they would be processed block-by-block. > >Now there is a disadvantage to this approach, and that is you have to wait for the whole thing to be encrypted before you can start doing the IO. I'm not sure how big a problem that is but if it is bad enough to affect performance, we can look into adding >some form of partial completion to the crypto API. > >Cheers, But assuming we have hardware accelerator that know to handle the IV generation for each sector, it will make sense to send out to the hardware the maximum block size as this will allow us to better utilize the hardware and offload the software. So if possible we need to provide generic interface that will be able to optimize the hardware accelerates. Thx Ofir -- Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you. -- dm-devel mailing list dm-devel@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/dm-devel
