Hi Milan, On 21 December 2016 at 18:17, Milan Broz <gmazyland@xxxxxxxxx> wrote: > So the core problem is that your crypto accelerator can operate efficiently only > with bigger batch sizes. Thank you for the reply. Yes, that would be rather an improvement when having bigger block sizes. > How big blocks your crypto hw need to be able to operate more efficiently? > What about 4k blocks (no batches), could it be usable trade-off? The benchmark results for Qualcomm Snapdragon SoC's (mentioned below) show significant improvement with 4K blocks but in batches of all such contiguous segments in the block layer's request queue in the form of a chained scatterlist. However, it uses the algorithm 'aes-xts' instead of the conventional 'essiv-cbc-aes' used in dm-crypt. Also, it uses the device mapper dm-req-crypt instead of dm-cypt. http://nelenkov.blogspot.in/2015/05/hardware-accelerated-disk-encryption-in.html Section : 'Performance' Its reports and IO rate of 46.3MB/s compared to an IO rate of 25.1MB/s while using a software-based FDE (based on dm-crypt). But I am not sure how genuine this data is or how it was tested. Since qualcomm SoC's use hardware backed keystore for managing keys and since there is no easy way to make dm-crypt work with qualcomm's engines, I do not have solid benchmark data to show an improved performance when using 4k blocks. > With some (backward incompatible) changes in LUKS format I would like to see support > for encryption blocks equivalent to sectors size, so it basically means for 4k drive 4k > encryption block. > (This should decrease overhead, now is everything processed on 512 blocks only.) > > Support of bigger block sizes would be unsafe without additional mechanism that provides > atomic writes of multiple sectors. Maybe it applies to 4k as well on some devices though...) Did you mean write to the crypto output buffers or the actual disk write? I didn't quite understand how the block size for encryption affects atomic writes as it is the block layer which handles them. As far as dm-crypt is, concerned it just encrypts/decrypts a 'struct bio' instance and submits the IO operation to the block layer. > The above is not going against your proposal, I am just curious if this is enough > to provide better performance on your hw accelerator or not. May be I should be able to procure an open crypto board and get back to you with some results. Or may be show even a marginal improvement while using software algorithm by avoiding the crypto overhead for every 512 bytes. -Binoy -- dm-devel mailing list dm-devel@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/dm-devel
