On Tue, 3 Feb 2009 01:25:30 -0500 (EST) Mikulas Patocka <mpatocka@xxxxxxxxxx> wrote: > If you are going to put shared storage into your snapshots, look at this: > http://people.redhat.com/mpatocka/patches/kernel/new-snapshots/devel/ > > --- this is my snapshot store with Fujita/Daniel's store as a loadable > module. > > So if you are going to do shared storage interface, you must accommodate > both of these implementations into it. > > I still don't understand, how do you intend to patch it on the top of > existing snapshot code. Definitely, I wouldn't say that it will be an easy > task. Look at the code and have a fun with it. I expect that we will support the shared implementation(s) on the top of the existing snapshot code instead of inventing a new target_type (as Mikulas do with multisnap_*). If not, we can live without refactoring the existing snapshot code. But surely supporting the shared implementation(s) on the top of the existing snapshot code needs more refactoring. Jonathan, have you already started to work on it? -- dm-devel mailing list dm-devel@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/dm-devel