On Tue, 3 Feb 2009, FUJITA Tomonori wrote: > On Tue, 3 Feb 2009 01:25:30 -0500 (EST) > Mikulas Patocka <mpatocka@xxxxxxxxxx> wrote: > > > If you are going to put shared storage into your snapshots, look at this: > > http://people.redhat.com/mpatocka/patches/kernel/new-snapshots/devel/ > > > > --- this is my snapshot store with Fujita/Daniel's store as a loadable > > module. > > > > So if you are going to do shared storage interface, you must accommodate > > both of these implementations into it. > > > > I still don't understand, how do you intend to patch it on the top of > > existing snapshot code. Definitely, I wouldn't say that it will be an easy > > task. Look at the code and have a fun with it. > > I expect that we will support the shared implementation(s) on the top > of the existing snapshot code instead of inventing a new target_type > (as Mikulas do with multisnap_*). Alasdair is wanting to make it on the top of existing snapshots but I haven't heard from him any specific argument, just generalized talks how sharing code is good. So, please start saying some specific nongeneralized ideas how do you imagine to do it. I.e. instead od saying "sharing code is good", download stuff from http://people.redhat.com/mpatocka/patches/kernel/new-snapshots/devel/ and say *EXACTLY* which code (structures, functions...) you you want to share with existing snapshots. Instead of saying "we treat all snapshots like objects with method tables" look at actual method tables from in-kernel snapshots and my snapshots and say *WHICH* methods exactly are you going to join. --- then, we can discuss it and go somewhere. Abstract ideas about software engineering make no sense at this stage. > If not, we can live without refactoring the existing snapshot code. > > But surely supporting the shared implementation(s) on the top of the > existing snapshot code needs more refactoring. Jonathan, have you > already started to work on it? > > -- > dm-devel mailing list > dm-devel@xxxxxxxxxx > https://www.redhat.com/mailman/listinfo/dm-devel Mikulas -- dm-devel mailing list dm-devel@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/dm-devel
