Re: [PATCH v3 9/9] NFC: nfcmrvl: update device tree bindings for Marvell NFC

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




Hi Rob,

> Le 23 oct. 2015 à 15:18, Rob Herring <robh@xxxxxxxxxx> a écrit :
> 
>> On Fri, Oct 23, 2015 at 7:23 AM, Vincent Cuissard <cuissard@xxxxxxxxxxx> wrote:
>> Align NFC bindgins to use marvell instead of mrvl.
>> 
>> Signed-off-by: Vincent Cuissard <cuissard@xxxxxxxxxxx>
>> ---
>> Documentation/devicetree/bindings/net/nfc/nfcmrvl.txt | 12 ++++++------
>> drivers/nfc/nfcmrvl/i2c.c                             |  2 +-
>> drivers/nfc/nfcmrvl/spi.c                             |  2 +-
>> drivers/nfc/nfcmrvl/uart.c                            |  2 +-
>> 4 files changed, 9 insertions(+), 9 deletions(-)
>> 
>> diff --git a/Documentation/devicetree/bindings/net/nfc/nfcmrvl.txt b/Documentation/devicetree/bindings/net/nfc/nfcmrvl.txt
>> index 41058fc..0f95924 100644
>> --- a/Documentation/devicetree/bindings/net/nfc/nfcmrvl.txt
>> +++ b/Documentation/devicetree/bindings/net/nfc/nfcmrvl.txt
>> @@ -2,9 +2,9 @@
>> 
>> Required properties:
>> - compatible: Should be:
>> -  - "mrvl,nfc-uart" for UART devices
>> -  - "mrvl,nfc-i2c" for I2C devices
>> -  - "mrvl,nfc-spi" for SPI devices
>> +  - "marvell,nfc-uart" for UART devices
>> +  - "marvell,nfc-i2c" for I2C devices
>> +  - "marvell,nfc-spi" for SPI devices
> 
> There is no point in changing these and doing so breaks backwards compatibility.

There is no break since these 2 drivers are new. In the same patchset I first set mrvl and replace it to marvell since I figured out that this is the name for all other Marvell drivers.

> These bindings have a bigger issue in that it doesn't describe the
> hardware, but rather just something to bind the Linux driver. The
> compatible strings should be tied to what NFC chip you have (i.e. the
> part number).

Chips with same physical interface are compatible so I don't need to use a part number that's why I using a generic binding.

Br,
-- 
Vincent--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]
  Powered by Linux