Ezequiel, Joachim, all, El 16/10/15 a las 14:09, Joachim Eastwood escribió: > On 16 October 2015 at 17:41, Ezequiel Garcia > <ezequiel@xxxxxxxxxxxxxxxxxxxx> wrote: >> +DT bindings maintainers >> >> As per the documentation in >> Documentation/devicetree/bindings/submitting-patches.txt >> this binding should be patch 1/2. I see. I'll modify that. >> >> On 16 October 2015 at 11:07, Ariel D'Alessandro >> <ariel@xxxxxxxxxxxxxxxxxxxx> wrote: >>> Add the devicetree binding document for NXP LPC18xx EEPROM memory. >>> >>> Signed-off-by: Ariel D'Alessandro <ariel@xxxxxxxxxxxxxxxxxxxx> >>> --- >>> .../devicetree/bindings/nvmem/lpc18xx_eeprom.txt | 26 ++++++++++++++++++++++ >>> 1 file changed, 26 insertions(+) >>> create mode 100644 Documentation/devicetree/bindings/nvmem/lpc18xx_eeprom.txt >>> >>> diff --git a/Documentation/devicetree/bindings/nvmem/lpc18xx_eeprom.txt b/Documentation/devicetree/bindings/nvmem/lpc18xx_eeprom.txt >>> new file mode 100644 >>> index 0000000..372ff8c >>> --- /dev/null >>> +++ b/Documentation/devicetree/bindings/nvmem/lpc18xx_eeprom.txt >>> @@ -0,0 +1,26 @@ >>> +* NXP LPC18xx EEPROM memory NVMEM driver >>> + >>> +Required properties: >>> + - compatible: Should be "nxp,lpc1850-eeprom" >> >> Correct me if I'm wrong, but I believe not all LPC18xx/43xx devices >> have an EEPROM. >> >> Isn't it restricted to LPC18x7/LPC43x7 devices? > > The EEPROM can only be found on Flash devices. Flashless devices > doesn't have the EEPROM. Yes, you're right. LPC1850 is wrong, sorry. The UM10430 (LPC18xx User Manual) says that LPC18(5|3|2|1)(7|5|3|2) parts have flash and that the LPC185x/3x parts with flash also include the 16 kB EEPROM. I'll add this info in a new set of patches v2. > > >> Should the compatible be nxp,lpc1857-eeprom to avoid confusion? > > Yes, please. The EEPROM doesn't exist on LPC1850 so please use the > compatibility string from Ezequiel. OK. I'll fix this. Is there any reason for using lpc1857 instead of a different available one? Thanks! -- Ariel D'Alessandro, VanguardiaSur www.vanguardiasur.com.ar -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
