Re: [PATCH 2/2] DT: nvmem: Add NXP LPC18xx EEPROM memory binding documentation

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 16 October 2015 at 17:41, Ezequiel Garcia
<ezequiel@xxxxxxxxxxxxxxxxxxxx> wrote:
> +DT bindings maintainers
>
> As per the documentation in
> Documentation/devicetree/bindings/submitting-patches.txt
> this binding should be patch 1/2.
>
> On 16 October 2015 at 11:07, Ariel D'Alessandro
> <ariel@xxxxxxxxxxxxxxxxxxxx> wrote:
>> Add the devicetree binding document for NXP LPC18xx EEPROM memory.
>>
>> Signed-off-by: Ariel D'Alessandro <ariel@xxxxxxxxxxxxxxxxxxxx>
>> ---
>>  .../devicetree/bindings/nvmem/lpc18xx_eeprom.txt   | 26 ++++++++++++++++++++++
>>  1 file changed, 26 insertions(+)
>>  create mode 100644 Documentation/devicetree/bindings/nvmem/lpc18xx_eeprom.txt
>>
>> diff --git a/Documentation/devicetree/bindings/nvmem/lpc18xx_eeprom.txt b/Documentation/devicetree/bindings/nvmem/lpc18xx_eeprom.txt
>> new file mode 100644
>> index 0000000..372ff8c
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/nvmem/lpc18xx_eeprom.txt
>> @@ -0,0 +1,26 @@
>> +* NXP LPC18xx EEPROM memory NVMEM driver
>> +
>> +Required properties:
>> +  - compatible: Should be "nxp,lpc1850-eeprom"
>
> Correct me if I'm wrong, but I believe not all LPC18xx/43xx devices
> have an EEPROM.
>
> Isn't it restricted to LPC18x7/LPC43x7 devices?

The EEPROM can only be found on Flash devices. Flashless devices
doesn't have the EEPROM.


> Should the compatible be nxp,lpc1857-eeprom to avoid confusion?

Yes, please. The EEPROM doesn't exist on LPC1850 so please use the
compatibility string from Ezequiel.


regards,
Joachim Eastwood
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]
  Powered by Linux