Re: [PATCH v3 1/3] tty: serial core: provide a method to search uart by phandle

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




Hi Nikolaus,

[auto build test WARNING on tty/tty-next -- if it's inappropriate base, please suggest rules for selecting the more suitable base]

url:    https://github.com/0day-ci/linux/commits/H-Nikolaus-Schaller/UART-slave-device-support-goldelico-version/20151017-021238
config: i386-randconfig-s1-201541 (attached as .config)
reproduce:
        # save the attached .config to linux build tree
        make ARCH=i386 

All warnings (new ones prefixed by >>):

   drivers/tty/serial/serial_core.c: In function 'devm_serial_uart_release':
>> drivers/tty/serial/serial_core.c:64:20: warning: unused variable 'uart' [-Wunused-variable]
     struct uart_port *uart = *(struct uart_port **)res;
                       ^

vim +/uart +64 drivers/tty/serial/serial_core.c

    48	
    49		if (!of_device_is_available(node))
    50			return ERR_PTR(-ENODEV);
    51	
    52		list_for_each_entry(uart, &uart_list, head) {
    53			if (node != uart->dev->of_node)
    54				continue;
    55	
    56			return uart;
    57		}
    58	
    59		return ERR_PTR(-EPROBE_DEFER);
    60	}
    61	
    62	static void devm_serial_uart_release(struct device *dev, void *res)
    63	{
  > 64		struct uart_port *uart = *(struct uart_port **)res;
    65	
    66		/* FIXME: I don't understand the serial subsystem well enough
    67		 * to know if we should call serial_put_uart(uart); here
    68		 */
    69	}
    70	
    71	/*
    72	 * This is used to lock changes in serial line configuration.

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Attachment: .config.gz
Description: Binary data


[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]
  Powered by Linux