On 09.09.2015 09:12, Andreas Dannenberg wrote: > Extend the bq2425x charger's device tree documentation to cover the > bq24250 and bq24257 devices as well as recent feature additions. > > Signed-off-by: Andreas Dannenberg <dannenberg@xxxxxx> Hi, Thanks for updates. Everything pointed previous looks good. After looking at Ramakrishna Pallala's (Cc-ed) patch ("power: bq24261_charger: Add support for TI BQ24261 charger") I have only one comment below. > --- > .../devicetree/bindings/power/bq24257.txt | 21 ------- > .../devicetree/bindings/power/bq2425x.txt | 70 ++++++++++++++++++++++ > 2 files changed, 70 insertions(+), 21 deletions(-) > delete mode 100644 Documentation/devicetree/bindings/power/bq24257.txt > create mode 100644 Documentation/devicetree/bindings/power/bq2425x.txt > > diff --git a/Documentation/devicetree/bindings/power/bq24257.txt b/Documentation/devicetree/bindings/power/bq24257.txt > deleted file mode 100644 > index 5c9d394..0000000 > --- a/Documentation/devicetree/bindings/power/bq24257.txt > +++ /dev/null > @@ -1,21 +0,0 @@ > -Binding for TI bq24257 Li-Ion Charger > - > -Required properties: > -- compatible: Should contain one of the following: > - * "ti,bq24257" > -- reg: integer, i2c address of the device. > -- ti,battery-regulation-voltage: integer, maximum charging voltage in uV. > -- ti,charge-current: integer, maximum charging current in uA. > -- ti,termination-current: integer, charge will be terminated when current in > - constant-voltage phase drops below this value (in uA). > - > -Example: > - > -bq24257 { > - compatible = "ti,bq24257"; > - reg = <0x6a>; > - > - ti,battery-regulation-voltage = <4200000>; > - ti,charge-current = <1000000>; > - ti,termination-current = <50000>; > -}; > diff --git a/Documentation/devicetree/bindings/power/bq2425x.txt b/Documentation/devicetree/bindings/power/bq2425x.txt > new file mode 100644 > index 0000000..3e171c3 > --- /dev/null > +++ b/Documentation/devicetree/bindings/power/bq2425x.txt > @@ -0,0 +1,70 @@ > +Binding for TI bq2425x Li-Ion Charger > + > +Required properties: > +- compatible: Should contain one of the following: > + * "ti,bq24250" > + * "ti,bq24251" > + * "ti,bq24257" > +- reg: integer, i2c address of the device. > +- stat-gpios: GPIO used for the devices STAT_IN pin. Alternatively the pin can > + also be defined through the standard interrupt definition properties (see > + optional properties section below). Only use one method. > +- ti,battery-regulation-voltage: integer, maximum charging voltage in uV. > +- ti,charge-current: integer, maximum charging current in uA. > +- ti,termination-current: integer, charge will be terminated when current in > + constant-voltage phase drops below this value (in uA). > + > +Optional properties: > +- pg-gpios: GPIO used for connecting the bq2425x device PG (Power Good) pin. > + This pin is not available on all devices however it should be used if > + possible as this is the recommended way to obtain the charger's input PG > + state. If this pin is not specified a software-based approach for PG > + detection is used. > +- ti,current-limit: The maximum current to be drawn from the charger's input > + (in uA). If this property is not specified a USB D+/D- signal based charger > + type detection is used (if available) and the input limit current is set > + accordingly. If the D+/D- based detection is not available on a given device > + a default of 500,000 is used (=500mA). I understand this is different property than "ti,charge-current: integer, default charging current (in mA)" from bq24261_charger patch? This one is for setting limit on current drawn from the charger and the bq24261's is to limit current delivered to battery? Best regards, Krzysztof > +- ti,ovp-voltage: Configures the over voltage protection voltage (in uV). If > + not specified a default of 6,5000,000 (=6.5V) is used. > +- ti,in-dpm-voltage: Configures the threshold input voltage for the dynamic > + power path management (in uV). If not specified a default of 4,360,000 > + (=4.36V) is used. > +- ti,safety-timer-2x-enable: If this property is set to 1 the device's safety > + timer is extended (slowed down) by a factor of two. Setting this property > + to 0 or not providing it will leave the safety timer at its default > + setting. > +- interrupt-parent: Should be the phandle for the interrupt controller. Use in > + conjunction with "interrupts" and only in case "stat-gpios" is not used. > +- interrupts: Interrupt mapping for GPIO IRQ (configure for both edges). Use in > + conjunction with "interrupt-parent" and only in case "stat-gpios" is not > + used. > + > +Example: > + > +bq24257 { > + compatible = "ti,bq24257"; > + reg = <0x6a>; > + stat-gpios = <&gpio1 16 GPIO_ACTIVE_HIGH>; > + pg-gpios = <&gpio1 28 GPIO_ACTIVE_HIGH>; > + > + ti,battery-regulation-voltage = <4200000>; > + ti,charge-current = <1000000>; > + ti,termination-current = <50000>; > +}; > + > +Example: > + > +bq24250 { > + compatible = "ti,bq24250"; > + reg = <0x6a>; > + interrupt-parent = <&gpio1>; > + interrupts = <16 IRQ_TYPE_EDGE_BOTH>; > + > + ti,battery-regulation-voltage = <4200000>; > + ti,charge-current = <500000>; > + ti,termination-current = <50000>; > + ti,current-limit = <900000>; > + ti,ovp-voltage = <9500000>; > + ti,in-dpm-voltage = <4440000>; > +}; > -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html