Hi, > On Wed, Aug 12, 2015 at 09:30:58PM -0700, Loc Ho wrote: > > Okay... The 'inline' helps with the compiler warning. If I move all to > > header file with 'static inline' and wrapper around CONFIG_EDAC_DEBUG, > > don't I need to export and declare the variable 'edac_debugfs'? Are > > you okay with export this variable? > > You need to make edac_debugfs extern in the header and define it in > edac_mc_sysfs.c. > > But that's ok because edac_core.h will be included only by EDAC drivers > and they're supposed to see edac_debugfs anyway... > What's the point in having an accessor function that returns a driver internal variable when this variable is exported anyway? This will only further inconsistencies because half of the users will use the variable directly and the other half will use the accessor function. Lothar Waßmann -- ___________________________________________________________ Ka-Ro electronics GmbH | Pascalstraße 22 | D - 52076 Aachen Phone: +49 2408 1402-0 | Fax: +49 2408 1402-10 Geschäftsführer: Matthias Kaussen Handelsregistereintrag: Amtsgericht Aachen, HRB 4996 www.karo-electronics.de | info@xxxxxxxxxxxxxxxxxxx ___________________________________________________________ -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
