On Wed, Aug 12, 2015 at 09:30:58PM -0700, Loc Ho wrote: > Okay... The 'inline' helps with the compiler warning. If I move all to > header file with 'static inline' and wrapper around CONFIG_EDAC_DEBUG, > don't I need to export and declare the variable 'edac_debugfs'? Are > you okay with export this variable? You need to make edac_debugfs extern in the header and define it in edac_mc_sysfs.c. But that's ok because edac_core.h will be included only by EDAC drivers and they're supposed to see edac_debugfs anyway... Thanks. -- Regards/Gruss, Boris. ECO tip #101: Trim your mails when you reply. -- -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html