Hi, > >>> EXPORT_SYMBOL_GPL() if it is going to be used by modules. >> >> Better yet, move it to the header. > > I can't move it completely to the header and make it static. It will > generate a lot of compiler warning as it isn't used by other modules. > I will add EXPORT_SYMBOL_GPL() in the next version. Okay... The 'inline' helps with the compiler warning. If I move all to header file with 'static inline' and wrapper around CONFIG_EDAC_DEBUG, don't I need to export and declare the variable 'edac_debugfs'? Are you okay with export this variable? Or, it is static inline if not defined CONFIG_EDAC_DEBUG. Otherwise, just an extern header function and export it as well? -Loc -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
