Hi Ben Thank you for your patch > Based on work by Shinobu Uehara and Ben Dooks. This adds the > voltage switch operation needed for all UHS-I modes, but not > the tuning needed for SDR-104 which will come later. > > XXX The card_busy implementation is a bit of a guess. > > Signed-off-by: Ben Hutchings <ben.hutchings@xxxxxxxxxxxxxxx> If original patch was created by Shinobu/Ben Dooks, and you updated it, I prefer to add these guys on Signed-off-by line. > static const struct mmc_host_ops tmio_mmc_ops = { > .request = tmio_mmc_request, > .set_ios = tmio_mmc_set_ios, > .get_ro = tmio_mmc_get_ro, > .get_cd = mmc_gpio_get_cd, > .enable_sdio_irq = tmio_mmc_enable_sdio_irq, > + .start_signal_voltage_switch > + = tmio_mmc_start_signal_voltage_switch, > + .card_busy = tmio_mmc_card_busy, > .multi_io_quirk = tmio_multi_io_quirk, > }; I prefer to separate this patch for these 2 new callbacks if possible. -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html