ср, 12 бер. 2025 р. о 11:49 Krzysztof Kozlowski <krzk@xxxxxxxxxx> пише: > > On 12/03/2025 07:02, Svyatoslav Ryhel wrote: > >>> + > >>> + reg: > >>> + maxItems: 1 > >>> + > >>> + interrupts: > >>> + maxItems: 1 > >>> + > >>> + monitored-battery: true > >>> + > >>> + maxim,usb-connector: > >> > >> Just 'connector', so when we have a 3rd case, we don't have a 3rd > >> vendor. > >> > > > > Please, please be explicit and specific, you could not tell me this in > > git grep -C 3 connector: > > > v3, you could but you decided to fuck up v4 as well. So wise. > > We got a lot to review thus we make reviews concise. I understand that > it might lead to insufficient guidance, so more help in removing > workload from maintainers is always appreciated. > > Instead of using vulgar words towards us, please put a bit more effort > and look at other recent bindings how they do it. > > Review is provided in good faith and if it is by any chance incorrect, > it is enough to disagree instead of throwing things like above. That's > not acceptable. > > > Additionally, if you want a generic 'connector' which can be > > referenced as 'connector: true' then add one, ATM this is classified > > under your own terms as 'vendor property' and needs a vendor prefix. > > richtek,usb-connector is not the good example here. Your previous code here: Then what is a good example? This is the only example with binding Rob requested, > https://lore.kernel.org/all/20250225090014.59067-2-clamor95@xxxxxxxxx/ > > looks correct - you have there port. So where does charger_input point? > It pointed to the port I have removed because Rob in v3 said it was overkill and connector phandle was enough. May you resolve this inside and not to contradict one another. Thank you. > > > > >>> + description: > >>> + Phandle to a USB connector according to usb-connector.yaml. The connector > >>> + should be a child of the extcon device. > >> > >> 'extcon' is a Linuxism. Is there an actual requirement here that's not > >> *current* Linux requirements (which could change)? I assume the > >> requirement is to have vbus or some supply? > >> > > > > Pardon me, this schema is part of Linux kernel, no? I have no clue why > > Bindings are used by other projects as well and they live here because > of possibility of review by skilled people and due to size of the > community. It does not make them, in general, Linux specific. > > > you collectively decided to just ignore external connector detection > > devices. Ignorance does not affect the fact that such devices exist. > > We didn't. They are described. > > > > > And no, it does not need vbus not supply, it needs EXTCON > > There is no such thing as "extcon" from hardware point of view. Point us > to any standard or even wikipedia article describing it. > > > Best regards, > Krzysztof
