On Wed, Mar 12, 2025 at 1:03 AM Svyatoslav Ryhel <clamor95@xxxxxxxxx> wrote: > > вт, 11 бер. 2025 р. о 21:37 Rob Herring <robh@xxxxxxxxxx> пише: > > > > On Mon, Mar 10, 2025 at 10:02:36AM +0200, Svyatoslav Ryhel wrote: > > > Add bindings for Maxim MAX8971 charger. > > > > > > Signed-off-by: Svyatoslav Ryhel <clamor95@xxxxxxxxx> > > > --- > > > .../bindings/power/supply/maxim,max8971.yaml | 64 +++++++++++++++++++ > > > 1 file changed, 64 insertions(+) > > > create mode 100644 Documentation/devicetree/bindings/power/supply/maxim,max8971.yaml > > > > > > diff --git a/Documentation/devicetree/bindings/power/supply/maxim,max8971.yaml b/Documentation/devicetree/bindings/power/supply/maxim,max8971.yaml > > > new file mode 100644 > > > index 000000000000..d7b3e6ff6906 > > > --- /dev/null > > > +++ b/Documentation/devicetree/bindings/power/supply/maxim,max8971.yaml > > > @@ -0,0 +1,64 @@ > > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > > +%YAML 1.2 > > > +--- > > > +$id: http://devicetree.org/schemas/power/supply/maxim,max8971.yaml# > > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > > + > > > +title: Maxim MAX8971 IC charger > > > + > > > +maintainers: > > > + - Svyatoslav Ryhel <clamor95@xxxxxxxxx> > > > + > > > +description: > > > + The MAX8971 is a compact, high-frequency, high-efficiency switch-mode charger > > > + for a one-cell lithium-ion (Li+) battery. > > > + > > > +allOf: > > > + - $ref: power-supply.yaml# > > > + > > > +properties: > > > + compatible: > > > + const: maxim,max8971 > > > + > > > + reg: > > > + maxItems: 1 > > > + > > > + interrupts: > > > + maxItems: 1 > > > + > > > + monitored-battery: true > > > + > > > + maxim,usb-connector: > > > > Just 'connector', so when we have a 3rd case, we don't have a 3rd > > vendor. > > > > Please, please be explicit and specific, you could not tell me this in > v3, you could but you decided to fuck up v4 as well. So wise. > Additionally, if you want a generic 'connector' which can be > referenced as 'connector: true' then add one, ATM this is classified > under your own terms as 'vendor property' and needs a vendor prefix. I don't care for your attitude, so I will be reviewing the 20+ other bindings a day I have to review and not yours. Rob
