On Thu, Feb 13, 2025 at 11:22:07AM +0100, Philipp Zabel wrote: > On Do, 2025-02-13 at 10:35 +0100, Krzysztof Kozlowski wrote: > > On Thu, Feb 13, 2025 at 10:08:54AM +0800, Inochi Amaoto wrote: > > > Some SoCs from Aspeed, Allwinner, Sophgo and Synopsys have > > > a simple reset controller by toggling bit. It is a hard time > > > for each device to add its own compatible to the driver. > > > Since this device share a common design, it is possible to > > > add a common device to reduce these unnecessary change. > > > > SoC components are rarely that simple and even if it is just a bit, > > usually it is part of one or few registers. > > Yes, in those cases (which are probably most of them), I would argue > this binding doesn't really fit. > Yes, I agree. > > Anyway, there are already bindings for reset-simple and I do not > > understand why this has to be duplicated. > > I think the motivation is to not have to add a new binding document and > modify reset-simple.c every time there is a new SoC. Yeah, this is the motivation for me to write this patch. It seems that I describe it in a wrong way. > I wonder if some of this can be mitigated by adding just the > binding document similar to trivial-devices.yaml, without the > actual "reset-simple" compatible. > It is better to keep the original compatible. Adding new base compatible will break existing device and make the migration hard. Regards, Inochi
