On Thu, Feb 13, 2025 at 10:08:54AM +0800, Inochi Amaoto wrote: > Some SoCs from Aspeed, Allwinner, Sophgo and Synopsys have > a simple reset controller by toggling bit. It is a hard time > for each device to add its own compatible to the driver. > Since this device share a common design, it is possible to > add a common device to reduce these unnecessary change. SoC components are rarely that simple and even if it is just a bit, usually it is part of one or few registers. Anyway, there are already bindings for reset-simple and I do not understand why this has to be duplicated. > > Add common binding for these kind generic reset controller. > > Signed-off-by: Inochi Amaoto <inochiama@xxxxxxxxx> > --- > .../bindings/reset/reset-simple.yaml | 42 +++++++++++++++++++ > 1 file changed, 42 insertions(+) > create mode 100644 Documentation/devicetree/bindings/reset/reset-simple.yaml > > diff --git a/Documentation/devicetree/bindings/reset/reset-simple.yaml b/Documentation/devicetree/bindings/reset/reset-simple.yaml > new file mode 100644 > index 000000000000..77584e23e8e8 > --- /dev/null > +++ b/Documentation/devicetree/bindings/reset/reset-simple.yaml > @@ -0,0 +1,42 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/reset/reset-simple.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Generic BIT Reset Controller > + > +maintainers: > + - Inochi Amaoto <inochiama@xxxxxxxxx> > + > +description: > + Some reset controller devices uses a simple method to perform > + assert/deassert by toggling bit. Some SoCs from Aspeed, Allwinner, > + Sophgo and Synopsys have this kind of reset controller instances. > + > +properties: > + compatible: > + enum: > + - reset-simple-high > + - reset-simple-low It would be one compatible and set of properties describing resets. Best regards, Krzysztof