On Mon, Feb 10, 2025 at 02:57:11PM -0800, Stephen Boyd wrote: > +$id: http://devicetree.org/schemas/usb/google,usb-pogo-keyboard.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Google USB Pogo Pin Keyboard > + > +maintainers: > + - Stephen Boyd <swboyd@xxxxxxxxxxxx> > + > +description: > + ChromeOS devices with a detachable keyboard have a set of five pogo pins that > + are the typical four pins for USB (D+/D-, VBUS, GND) and an extra pin for > + base detection. The detachable keyboard is a USB device that connects to the > + four USB pogo pins. > + > +properties: > + compatible: > + const: google,usb-pogo-keyboard > + > + '#address-cells': If there is going to be any new version: please use consistent quotes, either ' or " > + const: 1 > + > + '#size-cells': > + const: 0 > + > + port: > + $ref: /schemas/graph.yaml#/properties/port > + description: Connection to USB2 port providing USB HS signals > + required: > + - endpoint > + > +patternProperties: > + "^keyboard@[0-9a-f]{1,2}$": What does the unit address represent here? Why this isn't just "keyboard"? One connector usually has only one keyboard, right? Maybe it is only to fulfill the usb-device schema? The reg is there to represent USB hub or controller port, which is not true here. I don't have any idea how to solve it. I assume you need the keyboard child, right? Best regards, Krzysztof
