Hi Krzysztof!
On Tue, 2025-02-11 at 09:08 +0100, Krzysztof Kozlowski wrote:
> > > > +/ {
> > > > + osc: oscillator {
> > > > + compatible = "fixed-clock";
> > >
> > > I really doubt that external oscillator is a peripheral. This is either
> > > part of board or the SoC.
> >
> > This is actually a problem of the original cv18xx.dtsi [1]. Do you think
> > I need to fix it as part of my series? This would touch all the pure
> > RiscV boards (using CV18xx SoCs, not SG200x SoCs), which I could avoid
> > otherwise.
>
> You are moving the node out of cv18xx.dtsi, so you can move it to final
> place for example. But I do not insist, because I also do not know the
> final (truly correct) place - don't know the hardware here.
Fortunately, problem disappeared by itself in v2 [1], now I don't touch it any longer
and only move CPU and int controller into corresponding SoCs, so the oscillator
falls into "could be coded as a fixed-clock in the SoC DTSI" cathegory of the
coding style.
Link: https://lore.kernel.org/soc/20250210220951.1248533-2-alexander.sverdlin@xxxxxxxxx/
--
Alexander Sverdlin.
