Hi, On Sun, 9 Feb 2025 00:04:55 +0800 kernel test robot <lkp@xxxxxxxxx> wrote: > Hi Maxime, > > kernel test robot noticed the following build errors: > > [auto build test ERROR on net-next/main] > > url: https://github.com/intel-lab-lkp/linux/commits/Maxime-Chevallier/net-ethtool-Introduce-ETHTOOL_LINK_MEDIUM_-values/20250208-064223 > base: net-next/main > patch link: https://lore.kernel.org/r/20250207223634.600218-12-maxime.chevallier%40bootlin.com > patch subject: [PATCH net-next 11/13] net: phy: Only rely on phy_port for PHY-driven SFP > config: i386-buildonly-randconfig-005-20250208 (https://download.01.org/0day-ci/archive/20250208/202502082347.tFufJ529-lkp@xxxxxxxxx/config) > compiler: clang version 19.1.3 (https://github.com/llvm/llvm-project ab51eccf88f5321e7c60591c5546b254b6afab99) > reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250208/202502082347.tFufJ529-lkp@xxxxxxxxx/reproduce) > > If you fix the issue in a separate patch/commit (i.e. not just a new version of > the same patch/commit), kindly add following tags > | Reported-by: kernel test robot <lkp@xxxxxxxxx> > | Closes: https://lore.kernel.org/oe-kbuild-all/202502082347.tFufJ529-lkp@xxxxxxxxx/ > > All errors (new ones prefixed by >>): > > >> drivers/net/phy/qcom/qca807x.c:698:12: error: use of undeclared identifier 'phy_sfp_attach'; did you mean 'phy_attach'? > 698 | .attach = phy_sfp_attach, > | ^~~~~~~~~~~~~~ > | phy_attach > include/linux/phy.h:1912:20: note: 'phy_attach' declared here > 1912 | struct phy_device *phy_attach(struct net_device *dev, const char *bus_id, > | ^ > >> drivers/net/phy/qcom/qca807x.c:699:12: error: use of undeclared identifier 'phy_sfp_detach'; did you mean 'phy_detach'? > 699 | .detach = phy_sfp_detach, > | ^~~~~~~~~~~~~~ > | phy_detach > include/linux/phy.h:1924:6: note: 'phy_detach' declared here > 1924 | void phy_detach(struct phy_device *phydev); > | ^ > >> drivers/net/phy/qcom/qca807x.c:702:17: error: use of undeclared identifier 'phy_sfp_connect_phy' > 702 | .connect_phy = phy_sfp_connect_phy, > | ^ > >> drivers/net/phy/qcom/qca807x.c:703:20: error: use of undeclared identifier 'phy_sfp_disconnect_phy' > 703 | .disconnect_phy = phy_sfp_disconnect_phy, > | ^ > >> drivers/net/phy/qcom/qca807x.c:748:9: error: call to undeclared function 'phy_sfp_probe'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration] > 748 | ret = phy_sfp_probe(phydev, &qca807x_sfp_ops); > | ^ > 5 errors generated. Ah damned, I missed that qca807x now also supports SFP. I'll include a conversion fr that driver too in V2 (and add Robert in CC:) Thanks, Maxime
