Hey Krzysztof, On Fri, Jan 31, 2025 at 10:28:52PM +0100, Krzysztof Kozlowski wrote: > On 31/01/2025 17:47, Uwe Kleine-König wrote: > >> Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings > >> are fixed by another series. Ultimately, it is up to the platform > >> maintainer whether these warnings are acceptable or not. No need to reply > >> unless the platform maintainer has comments. > >> > >> If you already ran DT checks and didn't see these error(s), then > >> make sure dt-schema is up to date: > >> > >> pip3 install dtschema --upgrade > >> > >> > >> New warnings running 'make CHECK_DTBS=y for arch/arm/boot/dts/intel/' for 20250130074553.92023-2-u.kleine-koenig@xxxxxxxxxxxx: > > > > Maybe I can learn something here: Is there a command that only checks > > this single dtb file? > > > > You asked about this and I gave you the link to blog describing this twice. Ah, I thought I knew that blog entry and have to admit I didn't recheck. It seems I remembered wrongly. Sorry for that. While pointing to the docs only is legit in a review, I think you could reduce the effort for patch submitters (and so maybe also the number of patch submit iterations) if you mentioned the command to run that lists the problems. Of course not completely reading the fine documentation is no excuse. A bit related to that: I think diff --git a/Makefile b/Makefile index 4117cc79748b..e6bde20152f4 100644 --- a/Makefile +++ b/Makefile @@ -1759,7 +1759,7 @@ help: @echo ' Multiple levels can be combined with W=12 or W=123' @$(if $(dtstree), \ echo ' make CHECK_DTBS=1 [targets] Check all generated dtb files against schema'; \ - echo ' This can be applied both to "dtbs" and to individual "foo.dtb" targets' ; \ + echo ' This can be applied both to "dtbs" and to individual "$$vendor/$$machine.dtb" targets' ; \ ) @echo '' @echo 'Execute "make" or "make all" to build all targets marked with [*] ' would be an improvement now that vendor subdirs are usual. I didn't know that worked and I was annoyed more than once about that because I expected the right command to do that was make [...] arch/arm/boot/dts/intel/socfpga/socfpga_cyclone5_de10nano.dtb which doesn't work but is (only subjectively for me?) more intuitive than make [...] intel/socfpga/socfpga_cyclone5_de10nano.dtb given that the full path is also what you need for compiling individual C files and having to specify the full path of the file to build is the norm for the make build system. Best regards Uwe
Attachment:
signature.asc
Description: PGP signature
