On Thu, Jan 30, 2025 at 05:38:08PM -0600, Rob Herring (Arm) wrote: > > On Thu, 30 Jan 2025 08:45:53 +0100, Uwe Kleine-König wrote: > > This dts is enough to make the board boot to Linux with the rootfs on > > a micro SD card. > > > > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxx> > > --- > > Hello, > > > > changes since (implicit) v1 available at > > https://lore.kernel.org/linux-arm-kernel/20250128172917.4565-2-u.kleine-koenig@xxxxxxxxxxxx/: > > > > - Use rgmii-id for ethernet/mdio. (Andrew Lunn) > > - Add a compatible entry for the machine (only had the SoC before), > > fix compatible for accelerometer and various other small > > improvements, most of them pointed out by the dt checker. > > (Krzysztof Kozlowski) > > > > There are still warnings when the dtb is built, but they all originate > > from the SoC dtsi. > > Except for the ones with the board compatible... Yeah, understood that now. (My reference was a nearly empty dts file with just the includes and the compatible. I checked that the full dts doesn't create more warnings. That worked fine, but with that approach I missed the compatible warning.) v3 will contain another patch adding "terasic,de10-nano" to Documentation/devicetree/bindings/arm/altera.yaml. > My bot found new DTB warnings on the .dts files added or changed in this > series. > > Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings > are fixed by another series. Ultimately, it is up to the platform > maintainer whether these warnings are acceptable or not. No need to reply > unless the platform maintainer has comments. > > If you already ran DT checks and didn't see these error(s), then > make sure dt-schema is up to date: > > pip3 install dtschema --upgrade > > > New warnings running 'make CHECK_DTBS=y for arch/arm/boot/dts/intel/' for 20250130074553.92023-2-u.kleine-koenig@xxxxxxxxxxxx: Maybe I can learn something here: Is there a command that only checks this single dtb file? > arch/arm/boot/dts/intel/socfpga/socfpga_cyclone5_de10nano.dtb: /: compatible: 'oneOf' conditional failed, one must be fixed: > ['terasic,de10-nano', 'altr,socfpga-cyclone5', 'altr,socfpga'] is too short > ['terasic,de10-nano', 'altr,socfpga-cyclone5', 'altr,socfpga'] is too long I couldn't suppress a smile when reading the above two lines :-) Best regards Uwe
Attachment:
signature.asc
Description: PGP signature
