On Sat, Feb 01, 2025 at 01:15:29PM +0100, Paul Menzel wrote: > Dear Dmitry, > > > Thank you for the patch. > > Am 01.02.25 um 10:18 schrieb Dmitry Baryshkov: > > WCN3950 is another example of the WCN39xx BT/WiFI family of chips. It > > requires different firmware files and has different current > > requirements, so add it as a separate SoC type. > > Is the firmware publicly available already? (In patch 4/4 you write, it is, > and I found it [1].) I find such information helpful in commit messages, and > also the firmware names: > > • qca/cmbtfw12.tlv > • qca/cmbtfw13.tlv > • qca/cmnv12.bin > • qca/cmnv13.bin Ack, I will add it. > Do you also have a datasheet name to review the vregs? I have it, but I don't think it is public. > > > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx> > > --- > > drivers/bluetooth/btqca.c | 9 +++++++++ > > drivers/bluetooth/btqca.h | 1 + > > drivers/bluetooth/hci_qca.c | 25 +++++++++++++++++++++++++ > > 3 files changed, 35 insertions(+) > > […] > > The rest looks good. > > > Kind regards, > > Paul > > > [1]: https://git.kernel.org/pub/scm/linux/kernel/git/firmware/linux-firmware.git/commit/?id=421017641e6a6ef389190ac3edf67885183f3de0 -- With best wishes Dmitry
