On Fri, Jan 31, 2025 at 02:01:49PM +1300, Chris Packham wrote: > .../bindings/mfd/realtek,rtl9301-switch.yaml | 29 +++++++++++++++++++ > 1 file changed, 29 insertions(+) > > diff --git a/Documentation/devicetree/bindings/mfd/realtek,rtl9301-switch.yaml b/Documentation/devicetree/bindings/mfd/realtek,rtl9301-switch.yaml > index f053303ab1e6..89e10213a4ee 100644 > --- a/Documentation/devicetree/bindings/mfd/realtek,rtl9301-switch.yaml > +++ b/Documentation/devicetree/bindings/mfd/realtek,rtl9301-switch.yaml > @@ -28,6 +28,9 @@ properties: > reg: > maxItems: 1 > > + mdio-controller: > + $ref: /schemas/net/realtek,rtl9301-mdio.yaml# > + So this mdio-controller looks duplicated now. Why is it needed? > '#address-cells': > const: 1 > > @@ -41,6 +44,10 @@ patternProperties: > 'i2c@[0-9a-f]+$': > $ref: /schemas/i2c/realtek,rtl9301-i2c.yaml# > > + 'mdio-controller@[0-9a-f]+$': > + $ref: /schemas/net/realtek,rtl9301-mdio.yaml# > + > + Just one blank line. Best regards, Krzysztof