On Wed, Jan 29, 2025 at 07:30:55AM +0000, Kartik Rajput wrote: > Thanks for reviewing the patch Krzysztof! > > On Tue, 2025-01-28 at 08:52 +0100, Krzysztof Kozlowski wrote: > > External email: Use caution opening links or attachments > > > > > > On Tue, Jan 28, 2025 at 12:16:32PM +0530, Kartik Rajput wrote: [...] > > > + nvidia,utc-fifo-threshold: > > > + $ref: /schemas/types.yaml#/definitions/uint32 > > > + description: > > > + This property specifies the UTC TX and RX client FIFO > > > threshold in > > > + terms of occupancy. > > > + > > > + This property should have the same value as the burst size > > > (number > > > + of characters read by the Tegra UTC hardware at a time from > > > each > > > + client) which is configured by the bootloader. > > > > Title says this is a client, so quite confusing. Anyway, why is this > > board specific? > > The client FIFO threshold should match the burst size configured in the > UTC controller by bootloader. This value could change depending on what > bootloader has programmed. Hence, this is moved to the device-tree. > > > > > Also, missing constraints, missing units. Why common serial > > properties > > are not applicable? > > > > I do see current-speed defined in serial-peripheral-props.yaml, that > can be used here. I also see "rx-threshold" and "tx-threshold" > properties defined in serial.yaml, maybe those can be utilized here. I > will update this in v2. I suppose "rx-threshold" and "tx-threshold" could be used instead of the custom "nvidia,utc-fifo-threshold" property. It looks like the hardware has separate values for the threshold in both directions, so this would give us a more accurate description (though from the current state of affairs it looks like both are always going to be the same). I'm not so sure about "current-speed", though. There's no concept of speed for the UTC, right? It's effectively backed by a physical UART that will run at a certain speed, but given that it will multiplex data from a variety of sources, "current-speed" will not be accurate in many cases. Thierry
Attachment:
signature.asc
Description: PGP signature
