Hi Geert,
Thanks for the feedback.
> -----Original Message-----
> From: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>
> Sent: 28 January 2025 14:05
> Subject: Re: [PATCH 7/7] arm64: dts: renesas: r9a09g047e57-smarc: Enable SDHI1
>
> Hi Biju,
>
> On Sun, 26 Jan 2025 at 14:46, Biju Das <biju.das.jz@xxxxxxxxxxxxxx> wrote:
> > Enable SDHI1 on the RZ/G3E SMARC EVK platform using gpio regulator for
> > voltage switching.
> >
> > Signed-off-by: Biju Das <biju.das.jz@xxxxxxxxxxxxxx>
>
> Thanks for your patch!
>
> > --- a/arch/arm64/boot/dts/renesas/r9a09g047e57-smarc.dts
> > +++ b/arch/arm64/boot/dts/renesas/r9a09g047e57-smarc.dts
> > @@ -12,10 +12,40 @@
> > #include "rzg3e-smarc-som.dtsi"
> > #include "renesas-smarc2.dtsi"
> >
> > +/*
> > + * To enable uSD card on SDIO_USD:
> > + *
> > + * Switch bank - SW_OPT_MUX-1 (SW_SDIO_M2E):
> > + * 0 - SMARC SDIO signal is connected to uSD1
> > + * 1 - SMARC SDIO signal is connected to M.2 Key E connector
> > + */
> > +
> > / {
> > model = "Renesas SMARC EVK version 2 based on r9a09g047e57";
> > compatible = "renesas,smarc2-evk", "renesas,rzg3e-smarcm",
> > "renesas,r9a09g047e57", "renesas,r9a09g047";
> > +
> > + usd_vdd_3p3v: regulator-usd-vdd-3p3v {
> > + compatible = "regulator-fixed";
> > + regulator-name = "fixed-3.3V";
> > + regulator-min-microvolt = <3300000>;
> > + regulator-max-microvolt = <3300000>;
> > + regulator-boot-on;
> > + regulator-always-on;
> > + };
>
> Can't you just reuse reg_3p3v from rzg3e-smarc-som.dtsi?
OK.
>
> > +
> > + vqmmc_sdhi1_ext: regulator-vqmmc-sdhi1-ext {
> > + compatible = "regulator-gpio";
> > +
> > + regulator-name = "SDHI1 VccQ";
> > + regulator-min-microvolt = <1800000>;
> > + regulator-max-microvolt = <3300000>;
> > +
> > + gpios = <&pinctrl RZG3E_GPIO(1, 5) GPIO_ACTIVE_HIGH>;
>
> arch/arm64/boot/dts/renesas/r9a09g047e57-smarc.dts:44.37-38 syntax error
>
> Missing #include <dt-bindings/gpio/gpio.h>
Oops missed it. It was part of out of tree ethernet patch.
I will fix it.
>
> > +
> > + gpios-states = <0>;
> > + states = <3300000 0>, <1800000 1>;
> > + };
>
> Is there a specific reason why you are using an external regulator...
I have tested both. I just want to give an example for user,
how to choose external regulator and also, previously I tested SDIO using
M.2 Key E connector(WLAN,BT) with RZ/G3E board testing software.
So, thought of using similar changes here in mainline.
>
> > };
> >
> > &pinctrl {
> > @@ -23,9 +53,44 @@ scif_pins: scif {
> > pins = "SCIF_TXD", "SCIF_RXD";
> > renesas,output-impedance = <1>;
> > };
> > +
> > + sd1-pwr-en {
> > + gpio-hog;
> > + gpios = <RZG3E_GPIO(1, 6) GPIO_ACTIVE_HIGH>;
> > + output-high;
> > + line-name = "sd1_pwr_en";
> > + };
>
> ... and external (fixed) power enable, instead of the internal regulator, which uses the same two
> pins?
Same as above.
Cheers,
Biju
