On 28/01/2025 11:25, Swathi K S wrote:
> + Tesla ethernet devices based on dwmmac support Gigabit ethernet.
> +
> +allOf:
> + - $ref: snps,dwmac.yaml#
> +
> +properties:
> + compatible:
> + const: tesla,fsd-ethqos.yaml
> +
> + reg:
> + maxItems: 1
> +
> + interrupts:
> + maxItems: 1
> +
> + clocks:
> + minItems: 5
> + maxItems: 10
Why is this flexible?
Anyway, you need to list and describe the items instead of min/maxItems.
> +
> + clock-names:
> + minItems: 5
> + maxItems: 10
Same here.
> +
> + iommus:
> + maxItems: 1
> +
> + phy-mode:
> + enum:
> + - rgmii-id
> +
> +required:
> + - compatible
> + - reg
> + - interrupts
> + - clocks
> + - clock-names
> + - iommus
> + - phy-mode
> +
> +unevaluatedProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/clock/fsd-clk.h>
> + #include <dt-bindings/interrupt-controller/arm-gic.h>
> +
> + ethernet_1: ethernet@14300000 {
Please implement last comment from Rob.
> + compatible = "tesla,fsd-ethqos";
> + reg = <0x0 0x14300000 0x0 0x10000>;
And since there is going to be new version, switch to the preferred
indentation (4-space). Other option is 2 spaces, but not 8.
> +...
Best regards,
Krzysztof
