Re: [PATCH 12/12] ARM: dts: sun8i: add DTSI file for V853

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On 2025. 01. 10. 14:58, Krzysztof Kozlowski wrote:
On 10/01/2025 13:39, Andras Szemzo wrote:
+// Copyright (C) 2024 Andras Szemzo <szemzo.andras@xxxxxxxxx>
+
+#include <dt-bindings/clock/sun6i-rtc.h>
+#include <dt-bindings/clock/sun8i-v853-r-ccu.h>
+#include <dt-bindings/reset/sun8i-v853-r-ccu.h>
+#include <dt-bindings/clock/sun8i-v853-ccu.h>
+#include <dt-bindings/reset/sun8i-v853-ccu.h>
+#include <dt-bindings/interrupt-controller/arm-gic.h>
+#include <dt-bindings/power/allwinner,sun8i-v853-ppu.h>
+
+/ {
+	#address-cells = <1>;
+	#size-cells = <1>;
+
+	osc24M: osc24M-clk {

Only lowercase node names.

I don't agree. It is customary to write oscillator names with casing in line with the SI prefixes of their frequency, i.e. lowercase k, uppercase M/G/etc. (even though a millihertz oscillator rarely makes sense, it is best to stay consistent).

Bence





[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux