Dear Jakub,
Thank you for the reply.
Jakub Kicinski 於 1/15/2025 7:33 AM 寫道:
On Mon, 13 Jan 2025 13:54:34 +0800 Joey Lu wrote:
+ regmap_write(bsp_priv->regmap,
+ macid == 0 ? NVT_REG_SYS_GMAC0MISCR : NVT_REG_SYS_GMAC1MISCR, reg);
This is a pretty long line and you do it twice, so save the address
to a temp variable, pls
Got it!
+MODULE_LICENSE("GPL v2");
checkpatch insists:
WARNING: Prefer "GPL" over "GPL v2" - see commit bf7fbeeae6db ("module: Cure the MODULE_LICENSE "GPL" vs. "GPL v2" bogosity")
Understood. I will fix the warning.
BR,
Joey
