On 15/01/2025 10:09, Csókás Bence wrote: > Hi, > > On 2025. 01. 10. 14:58, Krzysztof Kozlowski wrote: >> On 10/01/2025 13:39, Andras Szemzo wrote: >>> +// Copyright (C) 2024 Andras Szemzo <szemzo.andras@xxxxxxxxx> >>> + >>> +#include <dt-bindings/clock/sun6i-rtc.h> >>> +#include <dt-bindings/clock/sun8i-v853-r-ccu.h> >>> +#include <dt-bindings/reset/sun8i-v853-r-ccu.h> >>> +#include <dt-bindings/clock/sun8i-v853-ccu.h> >>> +#include <dt-bindings/reset/sun8i-v853-ccu.h> >>> +#include <dt-bindings/interrupt-controller/arm-gic.h> >>> +#include <dt-bindings/power/allwinner,sun8i-v853-ppu.h> >>> + >>> +/ { >>> + #address-cells = <1>; >>> + #size-cells = <1>; >>> + >>> + osc24M: osc24M-clk { >> >> Only lowercase node names. > > I don't agree. It is customary to write oscillator names with casing in It is not customary in Linux kernel and DT bindings/DTS. See DTS coding style, see the clock bindings and preferred node naming. This is the DTS submitted to Linux kernel, thus it is bound by the rules expressed in the kernel. Best regards, Krzysztof