On Wed, Jan 15, 2025 at 02:57:04AM +0000, Jacky Chou wrote: > Hi Andrew and Ninad, > > > > > > > Thanks. What will be the "phy-mode" value after you make these changes? > > > > > > Will it be "rgmii-id" for MAC1..4? > > > > It should be. > > Perhaps we will keep using "rgmii" No. It is wrong. > The reason is we cannot be sure all PHYs have support for phy-mode property. > We will refer to the other MACs and PHYs driver about phy-mode and > rx/tx-internal-delay-ps properties how they implement. > > Currently, we will plan to implement RGMII delay in ftgmac100 driver based on > ethernet-controller.yaml. > > At same time, we will think how to configure these phy-mode "rgmii-rxid", "rgmii-txid" > and "rgmii-id in MAC driver. I already explain how this works once. Please read this thread again.... The MAC can apply the delays, but it must mask the phy-mode it passes to the PHY. Andrew
