回覆: [PATCH v2 05/10] ARM: dts: aspeed: system1: Add RGMII support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Andrew,

> > There are around 11 boards in Aspeed SOC with phy-mode set to "rgmii"
> > (some of them are mac0&1 and others are mac2&3). "rgmii-rxid" is only
> mine.
> >
> > No one in aspeed SOC using "rgmii-id".
> 
> O.K, so we have to be careful how we fix this. But the fact they are all equally
> broken might help here.
> 
> > > Humm, interesting. Looking at ftgmac100.c, i don't see where you
> > > configure the RGMII delays in the MAC?
> 
> This is going to be important. How are delays configured if they are not in the
> MAC driver?

The RGMII delay is adjusted on clk-ast2600 driver. Please refer to the following link.
https://github.com/AspeedTech-BMC/linux/blob/f52a0cf7c475dc576482db46759e2d854c1f36e4/drivers/clk/clk-ast2600.c#L1008

We recently plan to upstream to mainline this part about the RGMII delay configuration.
All MAC RGMII delay of ast2600 are configured on the SCU register.
As mentioned before, we would like to configure the RGMII TX/RX delay on BMC side.
Therefore, we use the "rgmii" and "rgmii-rxid" as the recommendation for our design.

Thanks,
Jacky




[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux