On 10/01/2025 13:33, paul-pl.chen wrote: > From: "Paul-pl.Chen" <paul-pl.chen@xxxxxxxxxxxx> > > Add mediatek,exdma.yaml to support EXDMA for MT8196. > > Signed-off-by: Paul-pl.Chen <paul-pl.chen@xxxxxxxxxxxx> > --- > The header used in examples: > #include <dt-bindings/clock/mt8196-clk.h> > #include <dt-bindings/power/mt8196-power.h> > are not upstreamed yet. Which makes this untestable and unmergeable. This cannot be accepted. Fix your dependencies or decouple from them. > It will be sent by related owner soon. Still this won't build and won't be possible to apply. > --- > .../display/mediatek/mediatek,exdma.yaml | 77 +++++++++++++++++++ > 1 file changed, 77 insertions(+) > create mode 100644 Documentation/devicetree/bindings/display/mediatek/mediatek,exdma.yaml > > diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,exdma.yaml b/Documentation/devicetree/bindings/display/mediatek/mediatek,exdma.yaml > new file mode 100644 > index 000000000000..385f5549dfaa > --- /dev/null > +++ b/Documentation/devicetree/bindings/display/mediatek/mediatek,exdma.yaml Filename matching compatible. Why is this in display? DMA goes to dma. > @@ -0,0 +1,77 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/display/mediatek/mediatek,exdma.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: MediaTek EXDMA > + > +maintainers: > + - Chun-Kuang Hu <chunkuang.hu@xxxxxxxxxx> > + - Philipp Zabel <p.zabel@xxxxxxxxxxxxxx> > + > +description: > + The MediaTek display overlap extended DMA engine, namely OVL_EXDMA or EXDMA, > + primarily functions as a DMA engine for reading data from DRAM with various > + DRAM footprints and data formats. For input sources in certain color formats > + and color domains, OVL_EXDMA also includes a color transfer function > + to process pixels into a consistent color domain. > + Missing ref to dma schemas. > +properties: > + compatible: > + const: mediatek,mt8196-exdma > + > + reg: > + maxItems: 1 > + > + clocks: > + items: > + - description: EXDMA Clock > + > + power-domains: > + maxItems: 1 > + > + mediatek,larb: > + $ref: /schemas/types.yaml#/definitions/phandle-array Why array? And isn't the property named mediatek,larbs? > + maxItems: 1 > + items: > + maxItems: 1 > + description: | > + A phandle to the local arbiters node in the current SoCs. > + Refer to bindings/memory-controllers/mediatek,smi-larb.yaml. > + > + iommus: > + maxItems: 1 > + > + '#dma-cells': > + const: 1 > + > +required: > + - compatible > + - reg > + - clocks > + - power-domains > + - mediatek,larb > + - iommus Best regards, Krzysztof
