Hi Krzysztof, On Fri, 2024-12-27 at 09:11 +0100, Krzysztof Kozlowski wrote: > > External email : Please do not click links or open attachments until > you have verified the sender or the content. > > > On Fri, Dec 20, 2024 at 01:07:54AM +0800, Jason-JH.Lin wrote: > > 1. Add compatible name and iommus property to mediatek,gce- > > mailbox.yaml > > for MT8196. > > > > - The compatible name "mediatek,mt8196-gce-mailbox" is added to > > ensure that the device tree can correctly identify and > > configure > > > This is 100% redundant statement. Don't state the obvious and don't > explain to us how DT works. > OK, I'll drop this. > > the GCE mailbox for the MT8196 SoC. > > > > - The iommus property is added to specify the IOMMU > > configuration > > for the GCE mailbox, ensuring proper memory management and > > access > > control. > > You should say whether device supports or does not support IOMMU. So > all > devices now work with IOMMU? I guess I asked about it already, no > improvements. So again, don't state the obvious. > Yes, I'll change the above statement as below: In MT8196, all the command buffers allocated and used by GCE device are working with IOMMU. > > > > 2. Add the Global Command Engine (GCE) binding header to define the > > abstrct symbol binding to the GCE hardware settings of GCE > > Thread > > typo Thanks, I'll fix it. > > > Priority, GCE Subsys ID and GCE Event for MT8196. > > > > - GCE Thread Priority: Defined to configure the priority level > > for > > each GCE hardware thread. This is necessary for proper > > scheduling > > and execution of commands in the GCE. > > > > - GCE Subsys ID: Defined to specify the subsystem ID for GCE > > clients. > > This is used to correctly address and access different > > subsystems > > within the GCE. > > > > - GCE Event: Defined to specify the events that the GCE can > > handle. > > These events are used by the driver to synchronize and manage > > hardware operations. > > > > Examples of the binding usage in the driver code: > > Drop all below from commit msg. Don't paste C code into the bindings. > OK, I'll drop them. Regards, Jason-JH.Lin > Best regards, > Krzysztof >
