On Fri, Dec 20, 2024 at 01:07:54AM +0800, Jason-JH.Lin wrote: > 1. Add compatible name and iommus property to mediatek,gce-mailbox.yaml > for MT8196. > > - The compatible name "mediatek,mt8196-gce-mailbox" is added to > ensure that the device tree can correctly identify and configure This is 100% redundant statement. Don't state the obvious and don't explain to us how DT works. > the GCE mailbox for the MT8196 SoC. > > - The iommus property is added to specify the IOMMU configuration > for the GCE mailbox, ensuring proper memory management and access > control. You should say whether device supports or does not support IOMMU. So all devices now work with IOMMU? I guess I asked about it already, no improvements. So again, don't state the obvious. > > 2. Add the Global Command Engine (GCE) binding header to define the > abstrct symbol binding to the GCE hardware settings of GCE Thread typo > Priority, GCE Subsys ID and GCE Event for MT8196. > > - GCE Thread Priority: Defined to configure the priority level for > each GCE hardware thread. This is necessary for proper scheduling > and execution of commands in the GCE. > > - GCE Subsys ID: Defined to specify the subsystem ID for GCE clients. > This is used to correctly address and access different subsystems > within the GCE. > > - GCE Event: Defined to specify the events that the GCE can handle. > These events are used by the driver to synchronize and manage > hardware operations. > > Examples of the binding usage in the driver code: Drop all below from commit msg. Don't paste C code into the bindings. Best regards, Krzysztof
