On 17/12/2024 09:42, Jacky Bai wrote: >> Subject: Re: [PATCH] arm64: dts: freescale: Add basic dtsi for imx943 >> >> On Thu, Dec 12, 2024 at 05:35:55PM +0800, Jacky Bai wrote: >>> The i.MX 943 applications processors integrate up to four Arm Cortex >>> A55 cores and supports functional safety with built-in 2x Arm Cortex >>> M33 and M7 cores which can be configured asa safety island. Optimizing >>> performance and power efficiency for Industrial, IoT and automotive >>> devices, i.MX 943 processors are built with NXP’s innovative Energy >>> Flex architecture. >>> >>> This patch adds the minimal dtsi support for i.MX943 with peripherals >>> like uart, edma, i2c, spi, mu, sai etc. >>> >>> Signed-off-by: Jacky Bai <ping.bai@xxxxxxx> >>> --- >>> arch/arm64/boot/dts/freescale/imx943-clock.h | 196 +++ >>> .../arm64/boot/dts/freescale/imx943-pinfunc.h | 1542 >> +++++++++++++++++ >>> arch/arm64/boot/dts/freescale/imx943-power.h | 41 + >>> arch/arm64/boot/dts/freescale/imx943.dtsi | 1284 >> ++++++++++++++ >>> 4 files changed, 3063 insertions(+) >>> create mode 100644 arch/arm64/boot/dts/freescale/imx943-clock.h >>> create mode 100644 arch/arm64/boot/dts/freescale/imx943-pinfunc.h >>> create mode 100644 arch/arm64/boot/dts/freescale/imx943-power.h >>> create mode 100644 arch/arm64/boot/dts/freescale/imx943.dtsi >>> >>> diff --git a/arch/arm64/boot/dts/freescale/imx943-clock.h >>> b/arch/arm64/boot/dts/freescale/imx943-clock.h >>> new file mode 100644 >>> index 000000000000..64b9d5d4051e >>> --- /dev/null >>> +++ b/arch/arm64/boot/dts/freescale/imx943-clock.h >>> @@ -0,0 +1,196 @@ >>> +/* SPDX-License-Identifier: GPL-2.0-only OR MIT */ >>> +/* >>> + * Copyright 2024 NXP >>> + */ >>> + >>> +#ifndef __CLOCK_IMX943_H >>> +#define __CLOCK_IMX943_H >>> + >>> +#define IMX943_CLK_EXT 0 >>> +#define IMX943_CLK_OSC32K 1 >>> +#define IMX943_CLK_OSC24M 2 >> >> >> Why exactly are you adding clock indices to header files? Nothing in commit >> msg explains that. > > These clock index macro defines will be used in dtsi or dts for clock reference. > I just follow the way that we have done for i.MX95. Anything need to be improved or refined? > For commit msg, I will add some explains in v2. It is fine, just unexpected, so you have entire commit msg to explain this. Best regards, Krzysztof
