On Thu, Dec 12, 2024 at 09:41:20PM +0530, Satya Priya Kakitapalli wrote:
> +
> +required:
> + - compatible
> + - reg
> + - interrupts
> + - io-channels
> + - io-channel-names
Binding looks ok, but this wasn't tested due to unneeded dependency.
Please decouple from dependency, so automation can properly test it.
> +
> +unevaluatedProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/interrupt-controller/irq.h>
> + #include <dt-bindings/iio/adc/qcom,spmi-adc5-gen3-pm8775.h>
> +
> + pmic {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + pmm8654au_0_tz: temperature-sensor@d700 {
Drop label.
> + compatible = "qcom,spmi-pm8775-mbg-tm";
> + reg = <0xd700>;
> + interrupts = <0x1 0xd7 0x0 IRQ_TYPE_EDGE_RISING>;
> + io-channels = <&pm8775_1_adc PM8775_ADC5_GEN3_DIE_TEMP(1)>;
> + io-channel-names = "thermal";
> + #thermal-sensor-cells = <0>;
> + };
> + };
> +
> + thermal-zones {
> + pm8775-mbg0-thermal {
Drop the nodes, not related.
Best regards,
Krzysztof
