Re: [PATCH net-next] dt-bindings: net: dsa: microchip,ksz: Improve example to a working one

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Andrew

Op di 10 dec 2024 om 17:18 schreef Andrew Lunn <andrew@xxxxxxx>:
>
> To some extent, the example is for the properties defined in the
> binding. For properties defined in other bindings, you should look at
> the examples in other bindings, and then glue it all together in a
> real .dts file.
>
> I don't know if Rob will accept this patch.
>
>         Andrew

To some extent I understand that perspective, but in this case for
example dsa-port itself has no example, I also struggled quite a bit
getting the example going (admittedly a bit due to my lack of
experience, figuring out the dt-schema tool really helped as well).
In most cases when I look at an example I see the full scope of what
it should be (or at least enough to get started from there), and this
one seemed a bit off in that regard as it showcases itself as an
example but is missing some critical details.
The microchip,lan yaml in contrast does define these properties and I
think it gives a much clearer picture of how to implement it in a
device tree than expecting people to figure out all the places they
need to look and how to glue that together.
I don't think it's straightforward for most people getting into device
trees to know how to glue that all together and knowing where to look
to begin with, in that sense I figured updating this example might
help others trying to get this up and running.

Best regards,
Jesse




[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux