On Tue, Dec 10, 2024 at 01:04:43PM +0100, Jesse Van Gavere wrote: > Currently the example will not work when implemented as-is as there are > some properties and nodes missing. > - Define two eth ports, one for each switch for clarity. > - Add mandatory dsa,member properties as it's a dual switch setup example. > - Add the mdio node for each switch and define the PHYs under it. > - Add a phy-mode and phy-handle to each port otherwise they won't come up. > - Add a mac-address property, without this the port does not come up, in > the example all 0 is used so the port replicates MAC from the CPU port To some extent, the example is for the properties defined in the binding. For properties defined in other bindings, you should look at the examples in other bindings, and then glue it all together in a real .dts file. I don't know if Rob will accept this patch. Andrew