On 04.12.2024 09:49:15, Ciprian Costea wrote: > From: Ciprian Marian Costea <ciprianmarian.costea@xxxxxxxxxxx> > > Add device type data for S32G2/S32G3 SoC. > > FlexCAN module from S32G2/S32G3 is similar with i.MX SoCs, but interrupt > management is different. > > On S32G2/S32G3 SoC, there are separate interrupts for state change, bus > errors, Mailboxes 0-7 and Mailboxes 8-127 respectively. > In order to handle this FlexCAN hardware particularity, first reuse the > 'FLEXCAN_QUIRK_NR_IRQ_3' quirk provided by mcf5441x's irq handling > support. Secondly, use the newly introduced > 'FLEXCAN_QUIRK_SECONDARY_MB_IRQ' quirk which handles the case where two > separate mailbox ranges are controlled by independent hardware interrupt > lines. > > Signed-off-by: Ciprian Marian Costea <ciprianmarian.costea@xxxxxxxxxxx> > --- Looks good to me! Unrelated to this patch, but I want to extend the "FLEXCAN hardware feature flags" table in "flexcan.h". Can you provide the needed information? > /* FLEXCAN hardware feature flags > * > * Below is some version info we got: > * SOC Version IP-Version Glitch- [TR]WRN_INT IRQ Err Memory err RTR rece- FD Mode MB > * Filter? connected? Passive detection ption in MB Supported? > * MCF5441X FlexCAN2 ? no yes no no no no 16 > * MX25 FlexCAN2 03.00.00.00 no no no no no no 64 > * MX28 FlexCAN2 03.00.04.00 yes yes no no no no 64 > * MX35 FlexCAN2 03.00.00.00 no no no no no no 64 > * MX53 FlexCAN2 03.00.00.00 yes no no no no no 64 > * MX6s FlexCAN3 10.00.12.00 yes yes no no yes no 64 > * MX8QM FlexCAN3 03.00.23.00 yes yes no no yes yes 64 > * MX8MP FlexCAN3 03.00.17.01 yes yes no yes yes yes 64 > * VF610 FlexCAN3 ? no yes no yes yes? no 64 > * LS1021A FlexCAN2 03.00.04.00 no yes no no yes no 64 > * LX2160A FlexCAN3 03.00.23.00 no yes no yes yes yes 64 > * > * Some SOCs do not have the RX_WARN & TX_WARN interrupt line connected. > */ regards, Marc -- Pengutronix e.K. | Marc Kleine-Budde | Embedded Linux | https://www.pengutronix.de | Vertretung Nürnberg | Phone: +49-5121-206917-129 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-9 |
Attachment:
signature.asc
Description: PGP signature