On 19/11/2024 21:36, Mikael Gonella-Bolduc via B4 Relay wrote:
> +
> + reg:
> + maxItems: 1
> +
> + interrupts:
> + maxItems: 1
> +
> + vdd-supply: true
> +
> +additionalProperties: false
This goes after required:
> +
> +required:
> + - compatible
> + - reg
Supply not required?
> +
> +examples:
> + - |
> + #include <dt-bindings/interrupt-controller/irq.h>
> +
> + i2c {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + apds9160@53 {
Node names should be generic. See also an explanation and list of
examples (not exhaustive) in DT specification:
https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation
> + compatible = "broadmobi,apds9160";
Use 4 spaces for example indentation. Or at least something consistent.
Best regards,
Krzysztof
