On 20/11/2024 18:18, Conor Dooley wrote: > On Tue, Nov 19, 2024 at 03:36:56PM -0500, Mikael Gonella-Bolduc via B4 Relay wrote: >> From: Mikael Gonella-Bolduc <mgonellabolduc@xxxxxxxxxxxx> >> >> Add device tree bindings for APDS9160 driver >> >> Signed-off-by: Mikael Gonella-Bolduc <mgonellabolduc@xxxxxxxxxxxx> >> --- >> .../bindings/iio/light/avago,apds9160.yaml | 50 ++++++++++++++++++++++ >> 1 file changed, 50 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/iio/light/avago,apds9160.yaml b/Documentation/devicetree/bindings/iio/light/avago,apds9160.yaml >> new file mode 100644 >> index 0000000000000000000000000000000000000000..12e196b297fe523e4d324156041ef9c6900676eb >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/iio/light/avago,apds9160.yaml >> @@ -0,0 +1,50 @@ >> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) >> +%YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/iio/light/avago,apds9160.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: Broadcom Combined Proximity & Ambient light sensor >> + >> +maintainers: >> + - Mikael Gonella-Bolduc <m.gonella.bolduc@xxxxxxxxx> >> + >> +description: | >> + Datasheet: https://docs.broadcom.com/docs/APDS-9160-003-DS >> + >> +properties: >> + compatible: >> + enum: >> + - avago,apds9160 >> + - broadmobi,apds9160 > > What is the difference between these two devices? There's no match data, > makes it seem like there should be a fallback going on here. Same device names suggest this is some legacy. We don't take new bindings for legacy stuff. Best regards, Krzysztof