On Fri, Nov 08, 2024 at 05:35:44PM +0800, Ramon Cristopher M. Calam wrote: > Add documentation for device tree bindings of LT8722. > > Signed-off-by: Ramon Cristopher M. Calam <ramoncristopher.calam@xxxxxxxxxx> > --- > .../regulator/adi,lt8722-regulator.yaml | 178 ++++++++++++++++++ > 1 file changed, 178 insertions(+) > create mode 100644 Documentation/devicetree/bindings/regulator/adi,lt8722-regulator.yaml > This wasn't tested, so limited review follows. Please use subject prefixes matching the subsystem. You can get them for example with 'git log --oneline -- DIRECTORY_OR_FILE' on the directory your patch is touching. For bindings, the preferred subjects are explained here: https://www.kernel.org/doc/html/latest/devicetree/bindings/submitting-patches.html#i-for-patch-submitters > diff --git a/Documentation/devicetree/bindings/regulator/adi,lt8722-regulator.yaml b/Documentation/devicetree/bindings/regulator/adi,lt8722-regulator.yaml > new file mode 100644 > index 000000000000..3fbf788d4154 > --- /dev/null > +++ b/Documentation/devicetree/bindings/regulator/adi,lt8722-regulator.yaml > @@ -0,0 +1,178 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +# Copyright (c) 2023 Analog Devices, Inc. > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/regulator/adi,lt8722-regulator.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Analog Devices LT8722 Ultracompact Full Bridge Driver Driver like motor driver or regulator? Or Linux driver? If the latter then, drop. Describe the hardware please. > + > +maintainers: > + - Ramon Cristopher Calam <ramoncristopher.calam@xxxxxxxxxx> > + > +description: | Do not need '|' unless you need to preserve formatting. That's all folks! More review when this is tested, please. Best regards, Krzysztof