> -----Original Message----- > From: Krzysztof Kozlowski <krzk@xxxxxxxxxx> > Sent: Friday, November 8, 2024 7:43 PM > To: Calam, Ramon Cristopher <RamonCristopher.Calam@xxxxxxxxxx> > Cc: linux-kernel@xxxxxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx; Liam Girdwood > <lgirdwood@xxxxxxxxx>; Mark Brown <broonie@xxxxxxxxxx>; Rob Herring > <robh@xxxxxxxxxx>; Krzysztof Kozlowski <krzk+dt@xxxxxxxxxx>; Conor Dooley > <conor+dt@xxxxxxxxxx> > Subject: Re: [PATCH 2/2] dt-bindings: regulator: Add adi,lt8722-regulator.yaml > > [External] > > On Fri, Nov 08, 2024 at 05:35:44PM +0800, Ramon Cristopher M. Calam > wrote: > > Add documentation for device tree bindings of LT8722. > > > > Signed-off-by: Ramon Cristopher M. Calam > > <ramoncristopher.calam@xxxxxxxxxx> > > --- > > .../regulator/adi,lt8722-regulator.yaml | 178 ++++++++++++++++++ > > 1 file changed, 178 insertions(+) > > create mode 100644 > > Documentation/devicetree/bindings/regulator/adi,lt8722-regulator.yaml > > > > This wasn't tested, so limited review follows. > > Please use subject prefixes matching the subsystem. You can get them for > example with 'git log --oneline -- DIRECTORY_OR_FILE' on the directory your > patch is touching. For bindings, the preferred subjects are explained here: > https://urldefense.com/v3/__https://www.kernel.org/doc/html/latest/devic > etree/bindings/submitting-patches.html*i-for-patch- > submitters__;Iw!!A3Ni8CS0y2Y!4oCmeTiTgVsrbS0h3A8z0TbxaKPm_GIn6rOz > 8q48wWGHHDiFUnSbWQNtfx1s1okiqOIwJh-jS1S68-GRpPAtAQ$ > > > diff --git > > a/Documentation/devicetree/bindings/regulator/adi,lt8722-regulator.yam > > l > > b/Documentation/devicetree/bindings/regulator/adi,lt8722-regulator.yam > > l > > new file mode 100644 > > index 000000000000..3fbf788d4154 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/regulator/adi,lt8722-regulator > > +++ .yaml > > @@ -0,0 +1,178 @@ > > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) # Copyright (c) > > +2023 Analog Devices, Inc. > > +%YAML 1.2 > > +--- > > +$id: > > +https://urldefense.com/v3/__http://devicetree.org/schemas/regulator/a > > +di,lt8722- > regulator.yaml*__;Iw!!A3Ni8CS0y2Y!4oCmeTiTgVsrbS0h3A8z0Tbxa > > +KPm_GIn6rOz8q48wWGHHDiFUnSbWQNtfx1s1okiqOIwJh-jS1S68- > GzivZhfQ$ > > +$schema: > > +https://urldefense.com/v3/__http://devicetree.org/meta-schemas/core.y > > > +aml*__;Iw!!A3Ni8CS0y2Y!4oCmeTiTgVsrbS0h3A8z0TbxaKPm_GIn6rOz8q48 > wWGHHD > > +iFUnSbWQNtfx1s1okiqOIwJh-jS1S68-E5-fGDNQ$ > > + > > +title: Analog Devices LT8722 Ultracompact Full Bridge Driver > > Driver like motor driver or regulator? Or Linux driver? If the latter then, drop. > Describe the hardware please. > The term 'driver' refers to the LT8722's function in controlling the full bridge output stage of the regulator. One side of the full bridge is driven by a pulse width modulation (PWM) buck power stage, while the other side is driven by a linear power stage. An integrated 25-bit DAC is used to control the output voltage. I will revise the title to ' Analog Devices LT8722 Ultracompact Full Bridge DC/DC Converter' for clarity and enhance the description with detailed hardware information. > > > + > > +maintainers: > > + - Ramon Cristopher Calam <ramoncristopher.calam@xxxxxxxxxx> > > + > > +description: | > > Do not need '|' unless you need to preserve formatting. > > That's all folks! More review when this is tested, please. > > Best regards, > Krzysztof Thanks, I will remove this in the next patch. Best regards, Ramon
