RE: [PATCH 2/2] dt-bindings: regulator: Add adi,lt8722-regulator.yaml

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> -----Original Message-----
> From: Rob Herring (Arm) <robh@xxxxxxxxxx>
> Sent: Friday, November 8, 2024 6:18 PM
> To: Calam, Ramon Cristopher <RamonCristopher.Calam@xxxxxxxxxx>
> Cc: Krzysztof Kozlowski <krzk+dt@xxxxxxxxxx>; Conor Dooley
> <conor+dt@xxxxxxxxxx>; Liam Girdwood <lgirdwood@xxxxxxxxx>; linux-
> kernel@xxxxxxxxxxxxxxx; Mark Brown <broonie@xxxxxxxxxx>;
> devicetree@xxxxxxxxxxxxxxx
> Subject: Re: [PATCH 2/2] dt-bindings: regulator: Add adi,lt8722-regulator.yaml
> 
> [External]
> 
> 
> On Fri, 08 Nov 2024 17:35:44 +0800, Ramon Cristopher M. Calam wrote:
> > Add documentation for device tree bindings of LT8722.
> >
> > Signed-off-by: Ramon Cristopher M. Calam
> <ramoncristopher.calam@xxxxxxxxxx>
> > ---
> >  .../regulator/adi,lt8722-regulator.yaml       | 178 ++++++++++++++++++
> >  1 file changed, 178 insertions(+)
> >  create mode 100644
> Documentation/devicetree/bindings/regulator/adi,lt8722-regulator.yaml
> >
> 
> My bot found errors running 'make dt_binding_check' on your patch:
> 
> yamllint warnings/errors:
> 
> dtschema/dtc warnings/errors:
> Error: Documentation/devicetree/bindings/regulator/adi,lt8722-
> regulator.example.dts:42.44-45 syntax error
> FATAL ERROR: Unable to parse input tree
> make[2]: *** [scripts/Makefile.dtbs:129:
> Documentation/devicetree/bindings/regulator/adi,lt8722-
> regulator.example.dtb] Error 1
> make[2]: *** Waiting for unfinished jobs....
> make[1]: *** [/builds/robherring/dt-review-ci/linux/Makefile:1442:
> dt_binding_check] Error 2
> make: *** [Makefile:224: __sub-make] Error 2
> 
> doc reference errors (make refcheckdocs):
> 
> See
> https://urldefense.com/v3/__https://patchwork.ozlabs.org/project/devicetr
> ee-bindings/patch/20241108093544.9492-3-
> ramoncristopher.calam@analog.com__;!!A3Ni8CS0y2Y!_KU8t2BD5P_t7WfxY
> jWxOUHnAG7bO5XoQOA1gbUBMObfWMLO9SM6NZUCyTgbSxcxmC93rYrTs
> 5Ombu0lvybSbA$
> 
> The base for the series is generally the latest rc1. A different dependency
> should be noted in *this* patch.
> 
> If you already ran 'make dt_binding_check' and didn't see the above
> error(s), then make sure 'yamllint' is installed and dt-schema is up to
> date:
> 
> pip3 install dtschema --upgrade
> 
> Please check and re-submit after running the above command yourself. Note
> that DT_SCHEMA_FILES can be set to your schema file to speed up checking
> your schema. However, it must be unset to test all examples with your
> schema.

I've checked and corrected the errors reported by 'make dt_binding_check'.
The error was caused by the missing parenthesis on the negative value of the
'regulator-min-microvolt' property.  I've rerun the command with the fix and
no longer see the error.  Will resubmit the patch soon.

Thanks,
Ramon




[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux